Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation - typos #712

Closed
wants to merge 1 commit into from
Closed

Documentation - typos #712

wants to merge 1 commit into from

Conversation

wzag
Copy link

@wzag wzag commented Jun 17, 2022

I believe it was a typo to initialize j twice

@wzag
typos?
de1517d 
I believe it was a typo to initialize j twice
@davideschiavone davideschiavone requested review from pascalgouedo and removed request for davideschiavone June 20, 2022 13:40
@davideschiavone
Copy link
Contributor

thanks @wzag for your PR - @pascalgouedo , the leader of the PULP extensions will review your proposal - meanwhile, may I ask you to do the PR again the dev branch instead of the master branch? thanks a lot
Davide

pascalgouedo
pascalgouedo suggested changes Jun 24, 2022
View reviewed changes
docs/source/corev_hw_loop.rst
@@ -111,7 +111,7 @@ a matrix addition.


At the beginning of the HWLoop, the registers %[i] and %[j] are 0.
The innermost loop, from start0 to end0, adds to %[i] three times 1 and
The innermost loop, from startO to endO, adds to %[i] three times 1 and
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The innermost loop, from startZ to endZ, adds to %[i] three times 1 and

docs/source/corev_hw_loop.rst
@@ -111,7 +111,7 @@ a matrix addition.


At the beginning of the HWLoop, the registers %[i] and %[j] are 0.
The innermost loop, from start0 to end0, adds to %[i] three times 1 and
The innermost loop, from startO to endO, adds to %[i] three times 1 and
it is executed 10x10 times. Whereas the outermost loop, from startO to endO,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's loop body is executed 10x10 times. Whereas the outermost loop, from startO to endO,

@davideschiavone
Copy link
Contributor

what's the status of this @pascalgouedo ? If we do not merge we should close

@pascalgouedo
Copy link

Hi @davide
First correction is ok and second one is not.
Moreover this PR is on master and not on dev so I think we should drop it.
I have anyway taken it into account in my local updates I am going to push at some time.

pascalgouedo pushed a commit to pascalgouedo/cv32e40p that referenced this pull request Sep 7, 2022
PR openhwgroup#712 correction
1c21de4 
Signed-off-by: Pascal Gouedo <[email protected]>
@pascalgouedo pascalgouedo added Component:Doc For issues in the Documentation (e.g. for README.md files) PARAM:PULP_XPULP Issue depends on the PULP_XPULP parameter labels Sep 9, 2022
@pascalgouedo
Copy link

This feedback has been included in PR #720.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalgouedo pascalgouedo pascalgouedo requested changes

Assignees
No one assigned
Labels
Component:Doc For issues in the Documentation (e.g. for README.md files) PARAM:PULP_XPULP Issue depends on the PULP_XPULP parameter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wzag @davideschiavone @pascalgouedo